Re: HEADS UP for gdth driver users

From: Ingo Oeser
Date: Sat Jun 10 2006 - 06:06:49 EST


Hi Achim,

Thanks for working on this!

On Friday, 9. June 2006 13:03, Leubner, Achim wrote:
> Attached you find a patch to remove the scsi_request interface from the
> gdth driver. The patch contains your first patch, the changes for
> removing the scsi_request interface and some changes to preserve the
> 2.4.x compatibility.
> We tested it and it should work fine. It would be great if it could be
> integrated in the 2.6.18 cycle.

Your driver also uses lots of kernel version dependent
code in the main driver file.

Please implement new kernel API functions using old kernel API
functions and put these into your existing gdth_kcompat.h file.

Rationale: Linux drivers are required to be forward compatible instead of
backward compatible. More details per private email, if your needed.

Other issues with your patch were already raised by Andrew and Christoph.


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/