Re: [PATCH] genirq: Fix missing initializer for unmask inno_irq_chip

[Thomas Gleixner]

On Thu, 2006-06-08 at 17:58 +0200, Thomas Gleixner wrote:
> >  it appears to work
> > provided you don't stress it.  As soon as I load the system up with
> > CF activity, a full-sized flood ping and hit "enter" a few times on
> > the console, it locks up solid - no oops, no nothing, the machine
> > just completely freezes.
> > 
> > This does not happen with the existing ARM IRQ code.
> > 
> > I'll try to debug this odd behaviour later today, but first I need to
> > resurect my NMI oopser code for this platform.

Russell, 

thanks for tracking this down. It turned out to be a reentrancy problem
which was silently ignored by the original ARM implementation.

I uploaded a new patch series which contains the ARM side fix and I
added error messages for that case at the appropriate places.

http://www.tglx.de/projects/armirq/2.6.17-rc6/patch-2.6.17-rc6-armirq4.patch

http://www.tglx.de/projects/armirq/2.6.17-rc6/patch-2.6.17-rc6-armirq4.patches.tar.bz2

Ingo, Ben,

can you please check whether the following patch does trigger any false
positives for you ?

	tglx

 kernel/irq/chip.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Index: linux-2.6.17-rc6/kernel/irq/chip.c
===================================================================
--- linux-2.6.17-rc6.orig/kernel/irq/chip.c	2006-06-08 19:26:16.000000000 +0200
+++ linux-2.6.17-rc6/kernel/irq/chip.c	2006-06-08 19:26:16.000000000 +0200
@@ -208,8 +208,11 @@
 
 	spin_lock(&desc->lock);
 
-	if (unlikely(desc->status & IRQ_INPROGRESS))
+	if (unlikely(desc->status & IRQ_INPROGRESS)) {
+		printk(KERN_ERR "handle_simple_irq reentered while "
+		       "processing irq %d\n", irq);
 		goto out_unlock;
+	}
 	desc->status &= ~(IRQ_REPLAY | IRQ_WAITING);
 	kstat_cpu(cpu).irqs[irq]++;
 
@@ -251,8 +254,11 @@
 	spin_lock(&desc->lock);
 	mask_ack_irq(desc, irq);
 
-	if (unlikely(desc->status & IRQ_INPROGRESS))
+	if (unlikely(desc->status & IRQ_INPROGRESS)) {
+		printk(KERN_ERR "handle_level_irq reentered while "
+		       "processing irq %d\n", irq);
 		goto out;
+	}
 	desc->status &= ~(IRQ_REPLAY | IRQ_WAITING);
 	kstat_cpu(cpu).irqs[irq]++;
 
@@ -273,9 +279,9 @@
 
 	spin_lock(&desc->lock);
 	desc->status &= ~IRQ_INPROGRESS;
-out:
 	if (!(desc->status & IRQ_DISABLED) && desc->chip->unmask)
 		desc->chip->unmask(irq);
+out:
 	spin_unlock(&desc->lock);
 }
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/