Re: 2.6.17-rc6-mm1

From: Stefan Richter
Date: Thu Jun 08 2006 - 02:33:59 EST


Chris Wright wrote:
* Stefan Richter (stefanr@xxxxxxxxxxxxxxxxx) wrote:
The pending_packet_queue is only accessed from within drivers/ieee1394/ieee1394_core.c, and only via net/core/skbuff.c's access functions for queueing/ dequeueing/ queuewalking. Or am I missing something?

Quick grep show following two irq handlers as examples:

ohci_irq_handler() | lynx_irq_handler()
hpsb_bus_reset()
abort_requests()
skb_dequeue()
spin_lock_irqsave()
That spin_lock is called directly from within irq handler.

Yes, definitely. What I wanted to reassure myself about was rather that no other net/ code besides skbuff.c's touches this queue. IOW only the ieee1394 low and mid layer control the contexts within which the queue lock is used.
--
Stefan Richter
-=====-=-==- -==- -=---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/