Re: [PATCH] fix generic HDLC synclink mismatch build error

From: Paul Fulghum
Date: Wed Jun 07 2006 - 20:22:15 EST


Roman Zippel wrote:
Hi,

On Wed, 7 Jun 2006, Paul Fulghum wrote:


-#ifdef CONFIG_HDLC_MODULE
+#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
#define CONFIG_HDLC 1
#endif


Please don't define your own config symbols, just use Kconfig for this, simply remove the prompts from your earlier patch and add the dependecies as Randy suggested.

Randy's patch defines config symbols, so I don't know what you are getting at.

--
Paul

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/