[patch, -rc5-mm3] lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c

From: Ingo Molnar
Date: Tue Jun 06 2006 - 04:09:41 EST



* J.A. Magallón <jamagallon@xxxxxxx> wrote:

> One more, could not find it already reported (if yes, sorry for the
> noise). It is not in lockdep-combo as 20060606.

indeed i missed that. The patch below should fix it.

------------------
Subject: lock validator: add local_irq_enable_in_hardirq() to ide-floppy.c
From: Ingo Molnar <mingo@xxxxxxx>

ide-floppy.c enables hardirqs in IRQ context. (build-tested)

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
---
drivers/ide/ide-floppy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/ide/ide-floppy.c
===================================================================
--- linux.orig/drivers/ide/ide-floppy.c
+++ linux/drivers/ide/ide-floppy.c
@@ -839,7 +839,7 @@ static ide_startstop_t idefloppy_pc_intr
"transferred\n", pc->actually_transferred);
clear_bit(PC_DMA_IN_PROGRESS, &pc->flags);

- local_irq_enable();
+ local_irq_enable_in_hardirq();

if (status.b.check || test_bit(PC_DMA_ERROR, &pc->flags)) {
/* Error detected */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/