Re: 2.6.17-rc5-mm3-lockdep - locking error in quotaon

[Arjan van de Ven]

> following confuses the code (and I agree that it's kind of ugly from
> quota code to do that):
>   i_mutex of inode containing quota file is acquired after all other
> quota locks. i_mutex of all other inodes is acquired before quota locks.
> Quota code makes sure (by resetting inode operations and setting special
> flag on inode) that noone tries to enter quota code while holding
> i_mutex on a quota file...

can you point this out in a bit more detail, eg where exactly is this
happening? I think it is in this bit
       /* As we bypass the pagecache we must now flush the inode so that
         * we see all the changes from userspace... */
        write_inode_now(inode, 1);
        /* And now flush the block cache so that kernel sees the changes
*/
        invalidate_bdev(sb->s_bdev, 0);
        mutex_lock(&inode->i_mutex);
        mutex_lock(&dqopt->dqonoff_mutex);
        if (sb_has_quota_enabled(sb, type)) {
                error = -EBUSY;
                goto out_lock;

but that doesn't quite match your description...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/