Re: [PATCH 2.6.17-rc5-mm3] ieee1394: hl_irqs_lock is taken in hardwareinterrupt context

[Stefan Richter]

I wrote:
> ohci1394 and pcilynx call highlevel_host_reset from their hardware
> interrupt handler (via hpsb_selfid_complete).

By the way, the hl->host_reset() handlers should be audited WRT 
possibilities to offload parts of them into tasklets, workqueues etc..

bad:
	csr.c::host_reset() ->
	http://bugzilla.kernel.org/show_bug.cgi?id=6070

OK:
	nodemgr.c::nodemgr_host_reset()
	sbp2.c::sbp2_host_reset()

looks OK to me:
	dv1394.c::dv1394_host_reset()

can't tell:
	eth1394.c::ether1394_host_reset()
	raw1394.c::host_reset()
--
Stefan Richter
-=====-=-==- -==- --=-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/