Re: [patch] fix smt nice lock contention and optimization

[Ingo Molnar]

* Con Kolivas <kernel@xxxxxxxxxxx> wrote:

> Could we make this neater with extra braces such as:
> 
>  	for_each_domain(this_cpu, tmp) {
> 		if (tmp->flags & SD_SHARE_CPUPOWER) {
>  			sd = tmp;
> 			break;
> 		}
> 	}
> 
> and same for the other uses of for_each ? I know it's redundant but 
> it's neater IMO when there are multiple lines of code below it.

yep, that's the preferred style when there are multiple lines below a 
loop.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/