Re: 2.6.17-rc5-mm1

[Roman Zippel]

Hi,

On Thu, 1 Jun 2006, Martin Bligh wrote:

> So the point is to enable the performance-affecting debug options by
> default, but provide one clear hook to turn them all off, with a name
> that's consistent over time, so we can do it in an automated fashion.

The latter is what Ingo's patch doesn't really do and the first should 
stay in -mm. If we talk about an -mm only patch we can relax the rules a 
little, my NACK was for mainline inclusion. The problem is that my request 
for a -mm only patch and other changes has been met with utter ignorance 
so far by Ingo.

> To me that means having clear name so people know which option to hook
> stuff under, and preferably not hiding stuff behind extra config options
> to make them harder to find. Maybe I've missed the point of what you
> were trying to do, but it seemed to not meet that.

Well, if you don't want to enable a number of options, it's still better 
to hide them completely. There are number of options by reorganizing the 
debug menu a little, it only depends if we're talking here are about a -mm 
only crutch or something which might be useful to more than a handful of 
people. A few extra config options are not really a problem as long as 
they are logically grouped together (instead of having to enable random 
options all over the place).

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/