RE: [PATCH 1/1] scsi : megaraid_{mm,mbox}: a fix on 64-bit DMAcapability check

[Ju, Seokmann]

Hi,
 
> Well, this really isn't quite right.  There are 32 bit platforms which
> will refuse a 64 bit DMA mask on principle.  You need to 
> retry with a 32
> bit mask before erroring out, exactly like you've done in 
> megaraid_sas.c
> 
> Also, it's a bit strange having a 32 bit mask set initially 
> in probe_one
> and then being reset in init_mbox.  Why not just consolidate 
> all the PCI
> register testing and mask setting in probe_one?
Thank you for the points!
A patch containing these changes will followed, soon.

Seokmann
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/