Re: [patch 03/61] lock validator: sound/oss/emu10k1/midi.c cleanup

[Alexey Dobriyan]

On Tue, May 30, 2006 at 12:51:53PM +0200, Takashi Iwai wrote:
> At Mon, 29 May 2006 18:33:17 -0700,
> Andrew Morton wrote:
> > 
> > On Mon, 29 May 2006 23:23:19 +0200
> > Ingo Molnar <mingo@xxxxxxx> wrote:
> > 
> > > move the __attribute outside of the DEFINE_SPINLOCK() section.
> > > 
> > > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > > Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> > > ---
> > >  sound/oss/emu10k1/midi.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > Index: linux/sound/oss/emu10k1/midi.c
> > > ===================================================================
> > > --- linux.orig/sound/oss/emu10k1/midi.c
> > > +++ linux/sound/oss/emu10k1/midi.c
> > > @@ -45,7 +45,7 @@
> > >  #include "../sound_config.h"
> > >  #endif
> > >  
> > > -static DEFINE_SPINLOCK(midi_spinlock __attribute((unused)));
> > > +static __attribute((unused)) DEFINE_SPINLOCK(midi_spinlock);
> > >  
> > >  static void init_midi_hdr(struct midi_hdr *midihdr)
> > >  {
> > 
> > I'll tag this as for-mainline-via-alsa.
> 
> Acked-by: Takashi Iwai <tiwai@xxxxxxx>
> 
> 
> It's OSS stuff, so feel free to push it from your side ;)

Why it is marked unused when in fact it's used?

[PATCH] Mark midi_spinlock as used

Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
---

--- a/sound/oss/emu10k1/midi.c
+++ b/sound/oss/emu10k1/midi.c
@@ -45,7 +45,7 @@
 #include "../sound_config.h"
 #endif
 
-static DEFINE_SPINLOCK(midi_spinlock __attribute((unused)));
+static DEFINE_SPINLOCK(midi_spinlock);
 
 static void init_midi_hdr(struct midi_hdr *midihdr)
 {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/