Re: Patch for atkbd.c from Ubuntu

From: Dmitry Torokhov
Date: Mon May 29 2006 - 00:58:48 EST


On Wednesday 24 May 2006 14:31, Pete Zaitcev wrote:
> Hi, Dmitry:
>
> What do you think about the attached? Apparently, this is needed to
> support Korean input keys. Please let me know if this can be included.
>
> Here's a bug entry for reference:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192637
>

Hi Pete,

Please look here:

http://bugzilla.kernel.org/show_bug.cgi?id=2817#c4

"I will not accept this patch (or any similar patch) to extend the atkbd.c
mapping table - only standard scancodes are allowed there. The table is
easily modified from userspace, and that is the way to go.

In the past I tried to fill the table with all the entries, but found out
that there are two or three keyboards competing for every position in the
scancode table, with a different keycode."

I continue to agree with Vojtech's position here. Because kernel does not
have ability to detect the kind of keyboard connected to a box (nor do we
really want to store all this data in the kernel) all fine tuning of AT
keymap should be done from userspace.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/