Re: [PATCH] irda: missing allocation result check inirlap_change_speed()

From: David Miller
Date: Thu May 25 2006 - 19:21:27 EST


From: Florin Malita <fmalita@xxxxxxxxx>
Date: Wed, 24 May 2006 20:13:26 -0400

> The skb allocation may fail, which can result in a NULL pointer
> dereference in irlap_queue_xmit().
>
> Coverity CID: 434.
>
> Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>

If the allocation fails we should probably do something
more interesting here, such as schedule a timer to try
again later. Otherwise the speed change will silently
never occur.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/