Re: [PATCH] scx200_acb: fix section mismatch warning

[Jean Delvare]

Hi Randy, all,

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> 
> Fix section mismatch warning reported by Äsmail DÃnmez:
> WARNING: drivers/i2c/busses/scx200_acb.o - Section mismatch: reference
> to .init.text: from .text after 'scx200_add_cs553x' (at offset 0x528)
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/i2c/busses/scx200_acb.c
> +++ linux-2617-rc5/drivers/i2c/busses/scx200_acb.c
> @@ -491,7 +491,7 @@ static struct pci_device_id divil_pci[] 
>  
>  #define MSR_LBAR_SMB		0x5140000B
>  
> -static int scx200_add_cs553x(void)
> +static __init int scx200_add_cs553x(void)
>  {
>  	u32	low, hi;
>  	u32	smb_base;
> 

Correct, I sent exactly the same patch to the the lm-sensors list and
Greg KH yesterday:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html

So this one is
Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>

Note that the section mismatch is harmless here (we have a non-__init
function sandwiched between two __init functions) but nevertheless this
kind of warning is never welcome in a final kernel release so let's get
the fix merged now.

Andrew, can you please push this to Linus?

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/