Re: [PATCH 1/3] mm: tracking shared dirty pages

From: Christoph Lameter
Date: Thu May 25 2006 - 12:27:09 EST


On Thu, 25 May 2006, Peter Zijlstra wrote:

> - rebased on top of David Howells' page_mkwrite() patch.

I am a bit confused about the need for Davids patch. set_page_dirty() is
already a notification that a page is to be dirtied. Why do we need it
twice? set_page_dirty could return an error code and the file system can
use the set_page_dirty() hook to get its notification. What we would need
to do is to make sure that set_page_dirty can sleep.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/