Re: [PATCH 2/4] x86-64: Calgary IOMMU - move valid_dma_directioninto the callers
From: Jeff Garzik
Date: Thu May 25 2006 - 00:34:31 EST
Jon Mason wrote:
From Andi Kleen's comments on the original Calgary patch, move
valid_dma_direction into the calling functions.
Signed-off-by: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Signed-off-by: Jon Mason <jdmason@xxxxxxxxxx>
Even though BUG_ON() includes unlikely(), this introduces additional
tests in very hot paths.
_Why_ do we need this at all?
I would prefer to NAK the patch, and fix the odd user that gets it
wrong. It becomes REALLY obvious that a driver has gotten this wrong,
REALLY quickly.
I see no need to burden critical hot paths with dumb checks like this.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/