Re: [Fastboot] Re: [PATCH 02/03] kexec: Avoid overwriting thecurrent pgd (V2, i386)

[Eric W. Biederman]

Vivek Goyal <vgoyal@xxxxxxxxxx> writes:

> On Wed, May 24, 2006 at 01:40:41PM +0900, Magnus Damm wrote:
>>  
>> @@ -170,45 +151,16 @@ void machine_kexec_cleanup(struct kimage
>>  NORET_TYPE void machine_kexec(struct kimage *image)
>>  {
>>  	unsigned long page_list;
>> -	unsigned long reboot_code_buffer;
>> -
>> +	unsigned long control_code;
>> +	unsigned long page_table_a;
>>  	relocate_new_kernel_t rnk;
>>  
>> -	/* Interrupts aren't acceptable while we reboot */
>> -	local_irq_disable();
>
> Why are you getting rid of this call? Looks sane to disable interrupts
> early.

Agreed, this and changing the segment and idt handling is gratuitous.
If you are going to make multiple unrelated changes place do them
as separate patches.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/