Re: [PATCH 10/14/] Doc. sources: expose laptop-mode

From: Bart Samwel
Date: Tue May 23 2006 - 04:38:39 EST


Randy.Dunlap wrote:
On Mon, 22 May 2006 07:23:13 +0200 Bart Samwel wrote:
Point for discussion: should the laptop_mode script really still be in laptop-mode.txt? AFAIK most distros use laptop-mode-tools or use their own scripts to control this. Furthermore, the existing script is mostly unmaintained, and it is full of bugs that were fixed long ago in laptop-mode-tools (which was originally a fork of the script). I think it would be better to replace it with a bit of documentation on which things a laptop mode control script *should* tweak, *may want to* tweak, etc., accompanied by an explanation why these tweaks are needed. I.e, an "annotated spec", as one would expect to find in documentation. I'll submit a patch to this effect when I find some time.

If it's really so unmaintained and mostly replaced, sounds like it should
be removed. OTOH, if you want to keep several source files and/or
scripts, I would prefer to see a laptop-mode subdirectory for them.

I'm all for completely removing the script, so no subdirectories needed as far as I'm concerned. I'll submit a patch to replace the script by some text explaining what such a script should do.

Cheers,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/