Re: [PATCH] s390: next_timer_interrupt overflow in stop_hz_timer

[Martin Schwidefsky]

On Mon, 2006-05-22 at 16:14 -0400, Dave Jones wrote:

> arch/s390/kernel/time.c: In function 'stop_hz_timer':
> arch/s390/kernel/time.c:275: error: expected ')' before 'next'
> arch/s390/kernel/time.c:275: error: expected ')' before 'jiffies'

Argh,
I really have to stop doing things in a hurry. This result in stupid
things like missing parentheses for a type cast.

blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.

--
From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>

[patch] s390: fix typo in stop_hz_timer.

Add missing parentheses for type cast to u64.

Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
---

 arch/s390/kernel/time.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -urpN linux-2.6/arch/s390/kernel/time.c linux-2.6-patched/arch/s390/kernel/time.c
--- linux-2.6/arch/s390/kernel/time.c	2006-05-23 09:10:41.000000000 +0200
+++ linux-2.6-patched/arch/s390/kernel/time.c	2006-05-23 09:04:47.000000000 +0200
@@ -273,7 +273,7 @@ static inline void stop_hz_timer(void)
 	next = next_timer_interrupt();
 	do {
 		seq = read_seqbegin_irqsave(&xtime_lock, flags);
-		timer = (__u64 next) - (__u64 jiffies) + jiffies_64;
+		timer = ((__u64) next) - ((__u64) jiffies) + jiffies_64;
 	} while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
 	todval = -1ULL;
 	/* Be careful about overflows. */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/