Re: [PATCH 1/9] namespaces: add nsproxy

[Eric W. Biederman]

Sam Vilain <sam@xxxxxxxxxx> writes:

> Serge E. Hallyn wrote:
>
>>@@ -1585,7 +1591,15 @@ asmlinkage long sys_unshare(unsigned lon
>> 
>> 	if (new_fs || new_ns || new_sigh || new_mm || new_fd || new_ulist) {
>> 
>>+		old_nsproxy = current->nsproxy;
>>+		new_nsproxy = dup_namespaces(old_nsproxy);
>>+		if (!new_nsproxy) {
>>+			err = -ENOMEM;
>>+			goto bad_unshare_cleanup_semundo;
>>+		}
>>+
>> 		task_lock(current);
>>  
>>
>
> We'll get lots of duplicate nsproxy structures before we move all of the
> pointers for those subsystems into it. Do we need to dup namespaces on
> all of those conditions?

Ugh.  Good catch.  The new nsproxy needs to be just for the fs and the uts
namespace.  

I guess that means that test should be moved up a few lines.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/