Re: [PATCH 1/6] nfs: "open code" the NFS direct write rescheduler

[Andrew Morton]

Chuck Lever <cel@xxxxxxxxxx> wrote:
>
> +	 * Prevent I/O completion while we're still rescheduling
> +	 */
> +	dreq->outstanding++;
> +

No locking.

>  	dreq->count = 0;
> +	list_for_each(pos, &dreq->rewrite_list) {
> +		struct nfs_write_data *data =
> +			list_entry(dreq->rewrite_list.next, struct nfs_write_data, pages);
> +
> +		spin_lock(&dreq->lock);
> +		dreq->outstanding++;
> +		spin_unlock(&dreq->lock);

Locking.

Deliberate?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/