Re: [PATCH] Register sysfs file for hotpluged new node take 2.

[Dave Hansen]

On Thu, 2006-05-18 at 14:50 +0900, Yasunori Goto wrote:
> +       if (new_pgdat) {
> +               ret = register_one_node(nid);
> +               /*
> +                * If sysfs file of new node can't create, cpu on the node
> +                * can't be hot-added. There is no rollback way now.
> +                * So, check by BUG_ON() to catch it reluctantly..
> +                */
> +               BUG_ON(ret);
> +       } 

How about we register the node in sysfs _before_ it is
set_node_online()'d?  Effectively an empty node with no memory and no
CPUs.  It might be a wee bit confusing to any user tools watching the
NUMA sysfs stuff, but I think it beats a BUG().

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/