Re: [discuss] Re: [PATCH 2/3] reliable stack trace support(x86-64)

From: Jan Beulich
Date: Thu May 18 2006 - 08:03:49 EST


>Three instructions? We might be still able to afford that.
>
>push/pop is probably not needed because the stack frame will be already
>set up (ok possibly after a few instructions, but a small window might be
>tolerable)

Okay, then I'll prepare a patch to that effect during the next couple of days.

>Maybe I'm dense but I still don't get - frame has a pt_regs so why
>isn't the caller allowed to know about that fact?

Because the fact that there is a regs fields and the PC is accessible through it is architecture specific, yet the
caller (kernel/unwind.c) ought to be architecture independent.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/