Re: [RFC: 2.6 patch] fs/bio.c: possible cleanups

[Jens Axboe]

On Tue, May 16 2006, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the follwing needlessly global function static:
>   - __bio_clone()

NAK, it's part of the API (and I just had to use it the other day with
fcache).

> - don't mark the following _global_ functions as inline:
>   - bio_phys_segments()
>   - bio_hw_segments()

Ack.

> - remove the following unused EXPORT_SYMBOL's:
>   - bio_phys_segments
>   - bio_hw_segments
>   - bio_map_kern
>   - bio_copy_user
>   - bio_uncopy_user

NAK, also part of the API. Leave them.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/