[PATCH -mm] fix erroneous strcmp in modpost.c

From: Sven Schuster
Date: Mon May 15 2006 - 15:06:36 EST



Hi Andrew,

attached patch fixes an erroneous strcmp in modpost.c which let the
build of some external modules (madwifi, vloopback) on 2.6.17-rc4-mm1
fail. Additionally a small codingstyle one-liner :-)

kind regards,

Sven

Signed-off-by: Sven Schuster <schuster.sven@xxxxxx>

--- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.orig 2006-05-15 20:49:14.000000000 +0200
+++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c 2006-05-15 20:49:30.000000000 +0200
@@ -1194,9 +1194,9 @@ static void read_dump(const char *fname,
*d != '\0')
goto fail;

- if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
+ if (strcmp(export, "EXPORT_SYMBOL_GPL") == 0)
export_type = 1;
- else if(strcmp(export, "EXPORT_SYMBOL") == 0)
+ else if (strcmp(export, "EXPORT_SYMBOL") == 0)
export_type = 0;
else
goto fail;

Attachment: pgp00000.pgp
Description: PGP signature