Re: [PATCH] x86 NUMA panic compile error

From: Ingo Molnar
Date: Mon May 15 2006 - 15:00:18 EST



* Andi Kleen <ak@xxxxxxx> wrote:

>
> > But still, referencing a variable which is implemented in
> > arch/i386/kernel/timers/timer_cyclone.c from within arch/i386/kernel/srat.c
> > is asking for trouble, no?
>
> Probably, but where would you define it instead? It kind of belongs
> into timer_cyclone.c

there should be a asm-i386/cyclone.h that properly defines this. (and to
make things more consistent, it could make it 0 even if
!CONFIG_X86_CYCLONE_TIMER)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/