Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes

From: Roland Dreier
Date: Mon May 15 2006 - 11:53:13 EST

Next message: Roland Dreier: "Re: [PATCH 41 of 53] ipath - disable interrupts while holding spinlock in RWQE get"
Previous message: Roland Dreier: "Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt"
In reply to: Bryan O'Sullivan: "[PATCH 35 of 53] ipath - some interrelated stability and cleanlinessfixes"
Next in thread: Bryan O'Sullivan: "[PATCH 13 of 53] ipath - limit number of SGEs and WRs per QP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This looks like a pastiche of several patches. Why can't it be split
up into logical pieces?

> Call dma_free_coherent without ipath_mutex held.

Why? Doesn't freeing work with the mutex held?

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Roland Dreier: "Re: [PATCH 41 of 53] ipath - disable interrupts while holding spinlock in RWQE get"
Previous message: Roland Dreier: "Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt"
In reply to: Bryan O'Sullivan: "[PATCH 35 of 53] ipath - some interrelated stability and cleanlinessfixes"
Next in thread: Bryan O'Sullivan: "[PATCH 13 of 53] ipath - limit number of SGEs and WRs per QP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]