Re: 2.6.17-rc3 - fs/namespace.c issue

From: Stephen Smalley
Date: Fri May 12 2006 - 13:32:19 EST


On Mon, 2006-05-01 at 14:33 -0700, Andrew Morton wrote:
> Valdis.Kletnieks@xxxxxx wrote:
> >
> > There seems to have been a bug introduced in this changeset:
> >
> > http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f6422f17d3a480f21917a3895e2a46b968f56a08
> >
> > Am running 2.6.17-rc3-mm1. When this changeset is applied, 'mount --bind'
> > misbehaves:
> >
> > > # mkdir /foo
> > > # mount -t tmpfs -o rw,nosuid,nodev,noexec,noatime,nodiratime none /foo
> > > # mkdir /foo/bar
> > > # mount --bind /foo/bar /foo
> > > # tail -2 /proc/mounts
> > > none /foo tmpfs rw,nosuid,nodev,noexec,noatime,nodiratime 0 0
> > > none /foo tmpfs rw 0 0
> >
> > Reverting this changeset causes both mounts to have the same options.
> >
> > (Thanks to Stephen Smalley for tracking down the changeset...)
> >
>
> (cc's added)

What's the verdict on this change in user-visible behavior for bind
mounts? Is it a legitimate change and userland just needs to adapt to
it, or is it a change to the kernel's stable ABI that needs to be
reverted? It still appears to be present in -rc4.

--
Stephen Smalley
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/