Re: [PATCH 2/9] nsproxy: incorporate fs namespace

From: Serge E. Hallyn
Date: Fri May 12 2006 - 12:53:57 EST


Quoting Dave Hansen (haveblue@xxxxxxxxxx):
> On Fri, 2006-05-12 at 10:24 -0500, Serge E. Hallyn wrote:
> >
> > - exit_utsname(current);
> > - exit_namespace(current);
> > - exit_nsproxy(current);
> > + exit_task_namespaces(current);
> > current->nsproxy = init_task.nsproxy;
> > - get_nsproxy(current->nsproxy);
> > - get_namespace(current->nsproxy->namespace);
> > - get_uts_ns(current->nsproxy->uts_ns);
> > + get_namespaces(current);
>
> That really cleans up the main path quite a bit. Very nice.
>
> For parity with exit_task_namespaces(), should that be called
> get_task_namespaces()?

Yup, that would make sense. Will update the patch in my git tree.

Though those functions be renamed when the namespaces->count becomes
#nsproxies. Getting a weird regression with that patch, though, so
won't be sending that out today.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/