Re: [PATCH] [PNP] 'modalias' sysfs export

From: Kay Sievers
Date: Fri May 12 2006 - 07:09:27 EST


On Tue, May 09, 2006 at 07:41:44PM +0200, Pozsar Balazs wrote:

> Basically I implemented the above things, to be precise:
> - the alias for the pnp device drivers are in the form "pnp:*dXXXYYYY*"
> instead of the old "pnp:dXXXYYYY*"
> - the alias for the pnp card drivers are in the form
> "pnp:cXXXYYYY*dXXXYYYY*dXXXYYYY*"
> instead of the old
> "pnp:cXXXYYYYdXXXYYYYdXXXYYYY*"
> _and_ the device id part are ordered
> - add a "modalias" file under sysfs for each pnp device, containing
> "pnp:dXXXYYYYdXXXYYYY..."
> where "dXXXYYYY" is appended for each pnp id the device has
> - add a "modalias" file under sysfs for each pnp card, containing
> "pnp:cXXXYYYYdXXXYYYYdXXXYYYY..."
> where "cXXXYYYY" is the card_id, and the device ids are appended
> after it, _ordered_.
>
>
> With this applied, I think we are close to be able to drop
> special-casing the pnp bus in udev rules.

That looks promising.

> What still needs to be done is exporting the MODALIAS env variable.
> (Sorry, I do not see how it could be added elegantly.)

Yeah, we really want the environment variable. You may do the composition
of the string in a separate function, that just writes to a bufferi, and use
it to fill the buffer of the uevent environment and the page of the sysfs
attribute. Like we did for input:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=bd37e5a951ad2123d3f51f59c407b5242946b6ba


Thanks,
Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/