Re: [openib-general] [PATCH 6/6] iSER Kconfig and Makefile

From: Roland Dreier
Date: Thu May 11 2006 - 14:28:39 EST


Or> Indeed since libiscsi does not have a CONFIG_ of its own, you
Or> need to set CONFIG_ISCSI_TCP to have libiscsi being built and
Or> then iser links with it.

Or> So there are two options here: either to set a CONFIG_LIBISCSI
Or> and select it by both CONFIG_ISCSI_TCP and
Or> CONFIG_INFINIBAND_ISER or the approach you were suggesting. I
Or> am cc-ing Mike Christie and James Bottomley on this email, if
Or> you guys have a preference, let me know and i can produce a
Or> patch to drivers/scsi/Kconfig and Makefile.

In the iser branch of my git tree I just added

obj-$(CONFIG_INFINIBAND_ISER) += libiscsi.o

to drivers/scsi/Makefile. So let me know if I should change that.

Or> Thanks to you for pointing these issues, also, in
Or> drivers/infiniband/Makefile

>> +obj-$(CONFIG_INFINIBAND_SRP) += ulp/iser/

Or> should be

>> +obj-$(CONFIG_INFINIBAND_ISER) += ulp/iser/

Thanks, I made a copy-and-paste error there. I pushed out a fixed tree.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/