Re: [patch 1/17] Infrastructure to mark exported symbols asunused-for-removal-soon

From: Paul Jackson
Date: Thu May 11 2006 - 04:07:05 EST


Arjan wrote:
> not in the configs I tested at least... but maybe I need to add a specific config to
> my set..

Dang - I think you're right.

The original version of the patch that provided the new routine
cpuset_mem_spread_node() on about Feb 2, 2006 required that EXPORT, as
in that version cpuset_mem_spread_node() was called from the inline
versions of page_cache_alloc() and page_cache_alloc_cold().

But the final version of the cpuset_mem_spread_node() patch, on about
Feb 9, 2006, does not seem to require that EXPORT, because the callers
page_cache_alloc() and page_cache_alloc_code() were taken -out-of-line-
for the configurations that made use of cpuset_mem_spread_node().

However the EXPORT had already been added on about Feb 6 or 7, when
everyone and his brother noticed that I had broken the build with my
Feb 2 patch.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/