Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

From: Keir Fraser
Date: Wed May 10 2006 - 02:40:59 EST



On 10 May 2006, at 00:51, Chris Wright wrote:

* Herbert Xu (herbert@xxxxxxxxxxxxxxxxxxx) wrote:
Chris Wright <chrisw@xxxxxxxxxxxx> wrote:

+ netdev->features = NETIF_F_IP_CSUM;

Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter
would seem to be in fact easier for a virtual driver, no?

That, I really don't know.

Checksum offload was added late to the virtual transport and currently not enough info is carried to identify protocol checksum fields in arbitrary locations. When we rev the virtual interface, and include a proper checksum-offset field, we'll be able to switch to NETIF_F_HW_CSUM.

-- Keir

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/