Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

From: Chris Wright
Date: Tue May 09 2006 - 19:34:07 EST


* Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> On Tue, May 09, 2006 at 12:00:34AM -0700, Chris Wright wrote:
> > The network device frontend driver allows the kernel to access network
> > devices exported exported by a virtual machine containing a physical
> > network device driver.
>
> Please don't add procfs code to new network drivers. Especially if it's oopsable
> like the code in this driver by simple device renaming.

Agreed, no reason to keep the cruft around. I thought I had a comment
of the sort in there.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/