Re: [Pcihpd-discuss] [PATCH] correct pciehp init recovery

From: Jan Beulich
Date: Tue May 09 2006 - 04:28:24 EST


>>> Andrew Morton <akpm@xxxxxxxx> 09.05.06 09:49 >>>
>"Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>>
>> >>> Kristen Accardi <kristen.c.accardi@xxxxxxxxx> 28.04.06 19:38 >>>
>> >On Fri, 2006-04-28 at 16:59 +0200, Jan Beulich wrote:
>> >> Clean up the recovery path from errors during pcie_init().
>> >>
>> >It's possible that this driver never actually requested an irq if was in
>> >poll mode. Then you will call free_irq, when what you really want to do
>> >is kill the timer that may have been started.
>>
>> Thanks for pointing this out, here's the updated patch:
>>
>> Clean up the recovery path from errors during pcie_init().
>>
>
>Well, it does more than clean things up. It fixes bugs.
>
>Could we have a more accurate and complete changelog please?

Clean up (fix) the recovery path from errors during pcie_init() by properly
undoing any initialization steps already carried out.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/