RE: [PATCH] tpm: update module dependencies (PNPACPI)

From: Brown, Len
Date: Mon May 08 2006 - 18:25:44 EST


>On Mon, 2006-05-08 at 17:59 -0400, Brown, Len wrote:
>> >The TIS driver is dependent upon information from the ACPI table for
>> >device discovery thus it compiles but does no actual work
>with out this
>> >dependency.
>> >
>> >Signed-off-by: Kylene Hall <kjhall@xxxxxxxxxx>
>> >---
>> > drivers/char/tpm/Kconfig | 2 +-
>> > 1 files changed, 1 insertion(+), 1 deletion(-)
>> >
>> >--- linux-2.6.17-rc3/drivers/char/tpm/Kconfig 2006-04-26
>> >21:19:25.000000000 -0500
>> >+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/Kconfig
>> >2006-05-08 16:11:03.707961750 -0500
>> >@@ -22,7 +22,7 @@ config TCG_TPM
>> >
>> > config TCG_TIS
>> > tristate "TPM Interface Specification 1.2 Interface"
>> >- depends on TCG_TPM
>> >+ depends on TCG_TPM && PNPACPI
>>
>> I think you want simply "ACPI" rather than "PNPACPI" here, yes?

>No I think I really want PNPACPI because I have a pnp_driver which
>probes based on a CID value. PNPACPI is dependent on ACPI. Am I
>misunderstanding something. It works with PNPACPI on but turning off
>only PNPACPI causes it to not work.

So if you boot with "pnpacpi=off" it fails to probe?
Nice to have proof that PNPACPI finally obsoletes PNPBIOS
on a real system in the field.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/