Re: functions named similar (pci_acpi_init)

From: Greg KH
Date: Thu Apr 27 2006 - 20:02:13 EST


On Thu, Apr 27, 2006 at 04:37:59PM -0700, Muthu Kumar wrote:
> Hi,
> While looking at something else, got drifted to looking into
> initcall<n>.init. I found two instance of pci_acpi_init() function,
> one in drivers/pci/pci-acpi.c and another in i386/pci/acpi.c.
> I understand this doesnot cause any problem since they are static, but
> someone new looking at the code could fall for it? Is it worth
> changing one of its name or should I just go away :)

If you think changing one of them would help future readers of the code,
sure, feel free to send a patch.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/