Re: [PATCH 1/2] mm: serialize OOM kill operations

From: Andi Kleen
Date: Wed Apr 26 2006 - 00:46:37 EST


Dave Peterson <dsp@xxxxxxxx> writes:
>
> Index: git7-oom/include/linux/sched.h
> ===================================================================
> --- git7-oom.orig/include/linux/sched.h 2006-04-25 16:19:40.000000000 -0700
> +++ git7-oom/include/linux/sched.h 2006-04-25 16:21:48.000000000 -0700
> @@ -350,6 +350,8 @@ struct mm_struct {
> /* aio bits */
> rwlock_t ioctx_list_lock;
> struct kioctx *ioctx_list;
> +
> + int oom_notify;

That wastes 4 bytes for a single bit. Please put a flag into some of the existing
flag bitmaps instead.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/