Re: [PATCH 3/3] Assert notifier_block and notifier_call are not ininit section

[Linus Torvalds]

On Mon, 24 Apr 2006, sekharan@xxxxxxxxxx wrote:
> 
> 	Feel free to drop this patch if you think it is not needed.

It's incorrect.

The init section will be free'd, and as a result can be re-allocated to 
other uses. Thus testing that data is not in the init-section makes no 
sense.

Testing for _code_ not being in the init section can be sensible, since 
code never gets re-allocated (modulo module code, but that's never in the 
init section). So checking the "notifier_call" part may be sensible, but 
checking the notifier block data pointer definitely is not.

Patches 1-2 applied.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/