Re: [v4l-dvb-maintainer] [PATCH] cx25840 driver in 2.6.16 -- adds CX25836 support

From: Hans Verkuil
Date: Sat Apr 22 2006 - 15:53:48 EST


Hi Scott,

Thank you for your patch! Nice work. I've integrated it into the cx25840
driver (with some tweaks).

Please check my mercurial tree at
http://www.linuxtv.org/hg/~hverkuil/cx25836 to see if my changes did
not break anything for you. For the most part the changes dealt with
preventing the cx25836/7 from touching cx25840-specific registers.

Please let me know if it is OK (or not) so that I can get it merged into
the main v4l-dvb repository. I also need a Signed-off-by line from you
(see http://www.linuxtv.org/v4lwiki/index.php/How_to_submit_patches)
before I can officially merge the code.

As I am also maintainer of ivtv I'm looking forward to your ivtv
patches. Please contact me when you are seriously starting work on
ivtv: work is in progress to merge ivtv into the kernel, and if you can
let me know in advance what sort of changes you need, then I can warn
you if the changes required for the kernel merge conflict with what you
need.

And for the record, AFAIK there is no driver for the TI TLV320AIC23B.

Regards,

Hans Verkuil

On Saturday 22 April 2006 01:33, Scott Alfter wrote:
> My company is working on a quad CX23416-based MPEG-2 compressor card.
> The hardware guy decided to use CX25836s to capture video, instead
> of the CX25840 that most everybody else uses. The main difference
> between the '836 and '840 is that the '840 captures both audio and
> video, while the '836 captures video only. The video-related
> commands between the two are mostly the same, but the chip needs a
> different initialization sequence and it'd probably be a good idea to
> keep audio-related commands away from it. It also doesn't need to
> have audio firmware loaded.
>
> This is my first attempt at a Linux kernel patch. I've tested it
> with NTSC input at 352x480 and 720x480, and it works well. I'm
> currently using it with a hacked version of ivtv 0.6.1. Those
> changes will eventually need to be released here as well, but the
> hardware design is still in a bit of flux. I also need to put
> together a driver for the audio capture chips used on the card, the
> TI TLV320AIC23B; there appears to be no driver in the kernel for that
> chip.
>
> The patch is attached; a test mailing indicated that Thunderbird
> attaches patches inline instead of encoded. The patch is also
> available from this URL:
>
> http://alfter.us/files/linux-2.6.16-cx25836.patch
>
> Scott Alfter
> salfter@xxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/