Re: acpi hotkey sysfs support

From: Pavel Machek
Date: Fri Apr 21 2006 - 15:21:06 EST


HI!

> > I have created a place under sysfs to have a unified place
> > to gather user input for common hotkey features.
> > http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10
> >
> > All of you are owner of a specific acpi hotkey driver.
> > Would you like to use that sysfs support to reduce the
> > unnecessary interface complexity.
>
> Yep, patch looks okay. It would be nice to format it linux-like,
> through. Space between if and (, and such stuff.
>
> SHOUTING_TYPEDEFS look bad to me, too.

One more thing... can we use input api for these events? Routing
buttons through /proc/acpi/event was mistake from day 0 :-(.

Pavel

--
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/