Re: [PATCH/RFC] s390: Hypervisor File System

[Michael Holzheu]

Hi Jörn

Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote on 04/21/2006 05:18:00 PM:
> On Fri, 21 April 2006 17:42:28 +0300, Pekka Enberg wrote:
> > On 4/21/06, Michael Holzheu <holzheu@xxxxxxxxxx> wrote:
> > > diff -urpN linux-2.6.16/fs/hypfs/hypfs.h linux-2.6.16-
> hypfs/fs/hypfs/hypfs.h
> > > --- linux-2.6.16/fs/hypfs/hypfs.h   1970-01-01 01:00:00.000000000
+0100
> > > +++ linux-2.6.16-hypfs/fs/hypfs/hypfs.h   2006-04-21 12:56:58.
> 000000000 +0200
> > > +static void inline remove_trailing_blanks(char *string)
> > > +{
> > > +   char *ptr;
> > > +   for (ptr = string + strlen(string) - 1; ptr > string; ptr--) {
> > > +      if (*ptr == ' ')
> > > +         *ptr = 0;
> > > +      else
> > > +         break;
> > > +   }
> > > +}
> >
> > Please consider moving this to lib/string.c and perhaps renaming it to
> > strstrip().
>
> If you do that, could you strip all whitespace?  I have a special
> function to kill a single newline, if present.  Looks to me like those
> two could be combined.

That would be ok for us, since we do not have any newlines
in our strings. I will include this in the next patch!

Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/