[2.6 patch] arch/i386/kernel/cpu/cpufreq/powernow-k8.c: fix a check-after-use

From: Adrian Bunk
Date: Tue Apr 18 2006 - 18:09:10 EST


This patch fixes a check-after-use introduced by commit
4211a30349e8d2b724cfb4ce2584604f5e59c299 and spotted by the Coverity
checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

arch/i386/kernel/cpu/cpufreq/powernow-k8.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

--- linux-2.6.17-rc1-mm3-full/arch/i386/kernel/cpu/cpufreq/powernow-k8.c.old 2006-04-18 20:32:27.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/arch/i386/kernel/cpu/cpufreq/powernow-k8.c 2006-04-18 20:33:02.000000000 +0200
@@ -905,14 +905,17 @@ static int powernowk8_target(struct cpuf
{
cpumask_t oldmask = CPU_MASK_ALL;
struct powernow_k8_data *data = powernow_data[pol->cpu];
- u32 checkfid = data->currfid;
- u32 checkvid = data->currvid;
+ u32 checkfid;
+ u32 checkvid;
unsigned int newstate;
int ret = -EIO;

if (!data)
return -EINVAL;

+ checkfid = data->currfid;
+ checkvid = data->currvid;
+
/* only run on specific CPU from here on */
oldmask = current->cpus_allowed;
set_cpus_allowed(current, cpumask_of_cpu(pol->cpu));

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/