Re: [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_rootstatic

[Corey Minyard]

Yes, I thought this had already been added.  Please add it.

Thanks,

-Corey

Adrian Bunk wrote:

>This patch makes the needlessly global struct proc_ipmi_root static.
>
>Besides this, it removes an unused #ifdef CONFIG_PROC_FS from 
>include/linux/ipmi.h.
>
>---
>
>This patch was already sent on:
>- 13 Apr 2006
>
>BTW: Please add an entry for IPMI to MAINTAINERS.
>
> drivers/char/ipmi/ipmi_msghandler.c |    3 +--
> include/linux/ipmi.h                |    4 ----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old	2006-04-12 22:32:08.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h	2006-04-12 22:32:20.000000000 +0200
>@@ -210,11 +210,7 @@
>  */
> #include <linux/list.h>
> #include <linux/module.h>
>-
>-#ifdef CONFIG_PROC_FS
> #include <linux/proc_fs.h>
>-extern struct proc_dir_entry *proc_ipmi_root;
>-#endif /* CONFIG_PROC_FS */
> 
> /* Opaque type for a IPMI message user.  One of these is needed to
>    send and receive messages. */
>--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old	2006-04-12 22:32:29.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c	2006-04-12 22:32:45.000000000 +0200
>@@ -57,8 +57,7 @@
> static int initialized = 0;
> 
> #ifdef CONFIG_PROC_FS
>-struct proc_dir_entry *proc_ipmi_root = NULL;
>-EXPORT_SYMBOL(proc_ipmi_root);
>+static struct proc_dir_entry *proc_ipmi_root = NULL;
> #endif /* CONFIG_PROC_FS */
> 
> #define MAX_EVENTS_IN_QUEUE	25
>
>  
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/