Re: [RFC: 2.6 patch] fs/ocfs2/: remove unused exports

[Mark Fasheh]

Hi Adrian,
	These are all cluster stack functions and the OCFS2 cluster stack is
pretty much OCFS2 specific right now. So technically one could say they can
all be unexported until used by another related module. I'd rather leave
some of the ones that could make sense as exports though.

On Fri, Apr 14, 2006 at 01:34:09PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL_GPL's:
> - cluster/heartbeat.c: o2hb_check_node_heartbeating_from_callback
Completes an API. Lets keep this one please :)

> - cluster/heartbeat.c: o2hb_stop_all_regions
Hmm, called by the quorum stuff, which right now is embedded in the same
module as heartbeat anyway. Can probably go.

> - cluster/nodemanager.c: o2nm_get_node_by_num
> - cluster/nodemanager.c: o2nm_configured_node_map
> - cluster/nodemanager.c: o2nm_get_node_by_ip
I could definitely see the file system using these.

> - cluster/nodemanager.c: o2nm_node_put
> - cluster/nodemanager.c: o2nm_node_get
Can go for now.

> - dlm/dlmmaster.c: dlm_migrate_lockres
Was exported for debugging only anyway AFAIR. Can go.

Thanks,
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@xxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/