Re: [Ext2-devel] [RFC][8/21]ext3 modify variables to exceed 2G

[Mingming Cao]

On Fri, 2006-04-14 at 18:23 +0900, Takashi Sato wrote:
> Thank you for your comment, Andreas.
> 
> > Takashi-san, please, it would make the code much more maintainable if the
> > changes made here would use new types for filesystem-wide block offsets
> > and for file-relative block offsets, as was previously discussed, instead
> > of just changing some variables to be unsigned long.  Like:
> > 
> > typedef unsigned long ext3_fsblk_t; # block offset in the filesystem
> > typedef unsigned long ext3_fscnt_t; # block count in the filesystem
> > typedef unsigned long ext3_fileblk_t; # block offset in a file
> 
> I agree that, but it will need a lots of work...
> Mingming, you got same comment from Andreas in "Extend ext3
> filesystem limit from 8TB to 16TB", did you do something about
> this?

No, I haven't get chance to do it yet. Please feel free to take it.:)

Laurent did some ground work for the filesystem wide physical block
number in his 64 bit ext3 patches. He changed physical block number from
"unsigned long" to "sector_t", that's probably a good start.

BTW, I think we should have one more:

typedef long ext3_grpblk_t; # block offset in the block group


Mingming

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/