Re: [PATCH] deinline a few large functions in vlan code v2

[David S. Miller]

From: Denis Vlasenko <vda@xxxxxxxxxxxxx>
Date: Tue, 11 Apr 2006 10:28:54 +0300

> But it saves some text (~5k total in all network drivers)
> and removes a branch on rx path on non-VLAN enabled kernels...

It removes "5K total" when you build every single networking driver
statically into the main kernel image.

Nobody does that except for build sanity testing.  Folks will
enable the drivers they need for their testing into a static
kernel, or build all the net drivers they want modular.

Please resist the urge to work on things like this in a robotic
fashion.  Consider whether the thing you're working on really matters
in real life, and whether the alternative you're providing is really
an overall improvement.  In this case you're "improving" a case only
kernel build testers will use, and the amount of ifdef's added by
your patches uglify the code immensely.  To me, that's a clear net
loss.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/