Re: include/asm-arm/memory.h changes break zaurus sl-5500 boot

[KAMEZAWA Hiroyuki]

On Mon, 3 Apr 2006 16:44:34 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> On Mon, 3 Apr 2006 08:36:53 +0100
> Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> Hmm..from include/asm-arm/arch-clps711x/memory.h
> 
> ==
> /*
>  * Given a kaddr, LOCAL_MAR_NR finds the owning node of the memory
>  * and returns the index corresponding to the appropriate page in the
>  * node's mem_map.
>  */
> #define LOCAL_MAP_NR(addr) \
>         (((unsigned long)(addr) & (NODE_MAX_MEM_SIZE - 1)) >> PAGE_SHIFT)
> ==
> 
> Is this comment wrong ???
> 
Russell-san

All of sub-arch's comment says "Given a kaddr" but all of them just uses "offset".
So, paddr can be given as arg. 
__va()(or pfn_to_kaddr()) adds unnecessary calcs, so paddr should be used instead of kaddr.
Right ?

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/