Re: [openib-general] updated InfiniBand 2.6.17 merge plans

From: Roland Dreier
Date: Fri Mar 31 2006 - 11:34:01 EST


Roland> * Get rid of option for building IPoIB and mthca debug
Roland> output unless EMBEDDED=y

Christoph> NACK. Just add a FOO_DEBUG config option, this has
Christoph> noþhing to do with EMBEDDED.

I think you misunderstood (probably because what I wrote was very
unclear). What I meant to say was that I wanted to make
CONFIG_INFINIBAND_IPOIB_DEBUG=y, without the option to disable it,
unless CONFIG_EMBEDDED is set. In Kconfig language, change it to:

config INFINIBAND_IPOIB_DEBUG
bool "IP-over-InfiniBand debugging" if EMBEDDED
depends on INFINIBAND_IPOIB
default y

Do you still have a problem with that? The rationale is that we want
the debugging output compiled in (it still needs to be enabled at
runtime) unless the user really really knows they don't want it,
because by the time we know we want the output, it's too late to
recompile to kernel.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/