Re: [PATCH 10/15] EDAC: edac_mc_add_mc() fix [1/2]

From: Andrew Morton
Date: Fri Mar 03 2006 - 15:47:06 EST


Dave Peterson <dsp@xxxxxxxx> wrote:
>
> On Thursday 02 March 2006 18:31, Andrew Morton wrote:
> > Dave Peterson <dsp@xxxxxxxx> wrote:
> > > This is part 1 of a 2-part patch set. The code changes are split into
> > > two parts to make the patches more readable.
> >
> > Will the code compile and run with just #1-of-2 applied?
>
> It should compile. Assuming that it does, would it still have been
> preferable to just combine the two into a single patch?

It's better as you had it. First patch moves the functions without
changing them, the second patch changes them. The mantra is "one concept
per patch".


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/